Conditionally use esm package
#499
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Jun 4, 2022
| @@ -1,8 +1,5 @@ | |||
| import path from 'path'; | |||
| import findup from 'findup-sync'; | |||
| import esm from 'esm'; | |||
There was a problem hiding this comment.
this is the main fix here. importing esm cannot happen in module-space because of the hax it employs.
rwjblue
reviewed
Jun 6, 2022
Comment on lines
+53
to
+59
| } catch { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires, node/no-missing-require | ||
| const esm = require('esm'); | ||
| const esmRequire = esm(module); | ||
|
|
||
| brocfile = esmRequire(brocfilePath); | ||
| } |
There was a problem hiding this comment.
Can we check the specific error code and only fallback to the esm version if we don't have some other (userland) error?
There was a problem hiding this comment.
I can't get this project to run at all locally, so so I can't see what error is thrown
1 task
|
I can confirm that removing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #498
Tested on: https://stackblitz.com/github/nullvoxpopuli/broccoli/tree/remove-esm
(for which the
esmpackage does not work at all)